[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 30/47] acpi nvdimm: fix device physical address b
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PULL 30/47] acpi nvdimm: fix device physical address base |
Date: |
Mon, 31 Oct 2016 10:20:32 +0100 |
On Sun, 30 Oct 2016 23:24:46 +0200
"Michael S. Tsirkin" <address@hidden> wrote:
> From: Xiao Guangrong <address@hidden>
>
> According to ACPI 6.0 spec, "Memory Device Physical Address
> Region Base" in memdev is defined as "This field provides the
> Device Physical Address base of the region". This field should
> be zero in our case
I'm not sure that it should be a zero,
care to point source which tells that it should be zero?
> Signed-off-by: Xiao Guangrong <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/acpi/nvdimm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> index bbb2cfd..c2f5caa 100644
> --- a/hw/acpi/nvdimm.c
> +++ b/hw/acpi/nvdimm.c
> @@ -289,8 +289,6 @@ static void
> nvdimm_build_structure_memdev(GArray *structures, DeviceState *dev)
> {
> NvdimmNfitMemDev *nfit_memdev;
> - uint64_t addr = object_property_get_int(OBJECT(dev), PC_DIMM_ADDR_PROP,
> - NULL);
> uint64_t size = object_property_get_int(OBJECT(dev), PC_DIMM_SIZE_PROP,
> NULL);
> int slot = object_property_get_int(OBJECT(dev), PC_DIMM_SLOT_PROP,
> @@ -314,7 +312,8 @@ nvdimm_build_structure_memdev(GArray *structures,
> DeviceState *dev)
>
> /* The memory region on the device. */
> nfit_memdev->region_len = cpu_to_le64(size);
> - nfit_memdev->region_dpa = cpu_to_le64(addr);
> + /* The device address starts from 0. */
> + nfit_memdev->region_dpa = cpu_to_le64(0);
>
> /* Only one interleave for PMEM. */
> nfit_memdev->interleave_ways = cpu_to_le16(1);
- [Qemu-devel] [PULL 21/47] virtio-crypto-pci: add virtio crypto pci support, (continued)
- [Qemu-devel] [PULL 21/47] virtio-crypto-pci: add virtio crypto pci support, Michael S. Tsirkin, 2016/10/30
- [Qemu-devel] [PULL 22/47] virtio-crypto: set capacity of algorithms supported, Michael S. Tsirkin, 2016/10/30
- [Qemu-devel] [PULL 23/47] virtio-crypto: add control queue handler, Michael S. Tsirkin, 2016/10/30
- [Qemu-devel] [PULL 24/47] virtio-crypto: add data queue processing handler, Michael S. Tsirkin, 2016/10/30
- [Qemu-devel] [PULL 25/47] cryptodev: introduce an unified wrapper for crypto operation, Michael S. Tsirkin, 2016/10/30
- [Qemu-devel] [PULL 26/47] virtio-crypto: using bh to handle dataq's requests, Michael S. Tsirkin, 2016/10/30
- [Qemu-devel] [PULL 27/47] virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer, Michael S. Tsirkin, 2016/10/30
- [Qemu-devel] [PULL 28/47] acpi nvdimm: fix wrong buffer size returned by DSM method, Michael S. Tsirkin, 2016/10/30
- [Qemu-devel] [PULL 29/47] acpi nvdimm: fix OperationRegion definition, Michael S. Tsirkin, 2016/10/30
- [Qemu-devel] [PULL 30/47] acpi nvdimm: fix device physical address base, Michael S. Tsirkin, 2016/10/30
- Re: [Qemu-devel] [PULL 30/47] acpi nvdimm: fix device physical address base,
Igor Mammedov <=
[Qemu-devel] [PULL 31/47] acpi nvdimm: fix ARG3 conflict, Michael S. Tsirkin, 2016/10/30
[Qemu-devel] [PULL 32/47] acpi nvdimm: fix Arg6 usage, Michael S. Tsirkin, 2016/10/30
[Qemu-devel] [PULL 34/47] acpi nvdimm: rename result_size to dsm_out_buf_siz, Michael S. Tsirkin, 2016/10/30
[Qemu-devel] [PULL 33/47] nvdimm acpi: compile nvdimm acpi code arch-independently, Michael S. Tsirkin, 2016/10/30
[Qemu-devel] [PULL 35/47] nvdimm acpi: use common macros instead of magic names, Michael S. Tsirkin, 2016/10/30
[Qemu-devel] [PULL 36/47] nvdimm acpi: prebuild nvdimm devices for available slots, Michael S. Tsirkin, 2016/10/30