[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/8] tests: check-qom-proplist: Use &error_ab
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/8] tests: check-qom-proplist: Use &error_abort to catch errors |
Date: |
Mon, 31 Oct 2016 11:14:48 +0100 |
On Fri, 28 Oct 2016 23:48:01 -0200
Eduardo Habkost <address@hidden> wrote:
> Use &error_abort so we don't ignore any errors on the property
> registration calls.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes series v2 -> v3:
> * Patch imported from "tests: A few check-qom-proplist fixes"
> series
>
> Changes series v3 -> v4:
> * Added &error_abort to more object_property_{add,del}_*()
> calls
> * Suggested-by: Igor Mammedov <address@hidden>
> ---
> tests/check-qom-proplist.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
> index 693dc4c..766a4a1 100644
> --- a/tests/check-qom-proplist.c
> +++ b/tests/check-qom-proplist.c
> @@ -123,7 +123,7 @@ static void dummy_init(Object *obj)
> object_property_add_bool(obj, "bv",
> dummy_get_bv,
> dummy_set_bv,
> - NULL);
> + &error_abort);
> }
>
>
> @@ -132,13 +132,13 @@ static void dummy_class_init(ObjectClass *cls, void
> *data)
> object_class_property_add_str(cls, "sv",
> dummy_get_sv,
> dummy_set_sv,
> - NULL);
> + &error_abort);
> object_class_property_add_enum(cls, "av",
> "DummyAnimal",
> dummy_animal_map,
> dummy_get_av,
> dummy_set_av,
> - NULL);
> + &error_abort);
> }
>
>
> @@ -239,13 +239,13 @@ static void dummy_dev_init(Object *obj)
> DummyBus *bus = DUMMY_BUS(object_new(TYPE_DUMMY_BUS));
> DummyBackend *backend = DUMMY_BACKEND(object_new(TYPE_DUMMY_BACKEND));
>
> - object_property_add_child(obj, "bus", OBJECT(bus), NULL);
> + object_property_add_child(obj, "bus", OBJECT(bus), &error_abort);
> dev->bus = bus;
> - object_property_add_child(OBJECT(bus), "backend", OBJECT(backend), NULL);
> + object_property_add_child(OBJECT(bus), "backend", OBJECT(backend),
> &error_abort);
looks like line is over 80 characters
with that fixed
Reviewed-by: Igor Mammedov <address@hidden>
> bus->backend = backend;
>
> object_property_add_link(obj, "backend", TYPE_DUMMY_BACKEND,
> - (Object **)&bus->backend, NULL, 0, NULL);
> + (Object **)&bus->backend, NULL, 0,
> &error_abort);
> }
>
> static void dummy_dev_unparent(Object *obj)
> @@ -274,7 +274,7 @@ static void dummy_bus_init(Object *obj)
> static void dummy_bus_unparent(Object *obj)
> {
> DummyBus *bus = DUMMY_BUS(obj);
> - object_property_del(obj->parent, "backend", NULL);
> + object_property_del(obj->parent, "backend", &error_abort);
> object_unparent(OBJECT(bus->backend));
> }
>
- [Qemu-devel] [PATCH v4 0/8] qdev class properties + abstract class support on device-list-properties, Eduardo Habkost, 2016/10/28
- [Qemu-devel] [PATCH v4 1/8] tests: check-qom-proplist: Remove duplicate "bv" property, Eduardo Habkost, 2016/10/28
- [Qemu-devel] [PATCH v4 2/8] tests: check-qom-proplist: Use &error_abort to catch errors, Eduardo Habkost, 2016/10/28
- Re: [Qemu-devel] [PATCH v4 2/8] tests: check-qom-proplist: Use &error_abort to catch errors,
Igor Mammedov <=
- [Qemu-devel] [PATCH v4 4/8] qdev: Extract property-default code to qdev_property_set_to_default(), Eduardo Habkost, 2016/10/28
- [Qemu-devel] [PATCH v4 6/8] qom: object_class_property_iter_init() function, Eduardo Habkost, 2016/10/28
- [Qemu-devel] [PATCH v4 5/8] qdev: Register static properties as class properties, Eduardo Habkost, 2016/10/28
- [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties, Eduardo Habkost, 2016/10/28
- [Qemu-devel] [PATCH v4 8/8] qdev: Warning about using qdev_property_add_static() in new code, Eduardo Habkost, 2016/10/28