[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] char: cadence: check baud rate generator and
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] char: cadence: check baud rate generator and divider values |
|
Date: |
Mon, 31 Oct 2016 13:42:04 +0000 |
On 28 October 2016 at 16:34, Alistair Francis
<address@hidden> wrote:
> On Thu, Oct 27, 2016 at 12:24 PM, P J P <address@hidden> wrote:
>> From: Prasad J Pandit <address@hidden>
>>
>> The Cadence UART device emulator calculates speed by dividing the
>> baud rate by a 'baud rate generator' & 'baud rate divider' value.
>> The device specification defines these register values to be
>> non-zero and within certain limits. Add checks for these limits
>> to avoid errors like divide by zero.
>>
>> Reported-by: Huawei PSIRT <address@hidden>
>> Signed-off-by: Prasad J Pandit <address@hidden>
>
> This looks good to me. I'll spin up a new patch for the migration fix
> next week (I won't have time today).
>
> Reviewed-by: Alistair Francis <address@hidden>
Applied to target-arm.next, thanks.
-- PMM