[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.8 9/9] tcg: correct 32-bit tcg_gen_ld8s_i64 sig
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL for-2.8 9/9] tcg: correct 32-bit tcg_gen_ld8s_i64 sign-extension |
Date: |
Mon, 31 Oct 2016 08:47:33 -0600 |
From: Joseph Myers <address@hidden>
The version of tcg_gen_ld8s_i64 for 32-bit systems does a load into
the low part of the return value - then attempts a sign extension into
the high part, but wrongly sets the high part to a sign extension of
itself rather than of the low part. This results in TCG internal
errors from the use of the uninitialized high part (in some GCC tests
of AArch64 NEON shift intrinsics, in particular). This patch corrects
the sign-extension logic, making it match other functions such as
tcg_gen_ld16s_i64.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Joseph Myers <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/tcg-op.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
index 4d125df..6e2fb35 100644
--- a/tcg/tcg-op.c
+++ b/tcg/tcg-op.c
@@ -817,7 +817,7 @@ void tcg_gen_ld8u_i64(TCGv_i64 ret, TCGv_ptr arg2,
tcg_target_long offset)
void tcg_gen_ld8s_i64(TCGv_i64 ret, TCGv_ptr arg2, tcg_target_long offset)
{
tcg_gen_ld8s_i32(TCGV_LOW(ret), arg2, offset);
- tcg_gen_sari_i32(TCGV_HIGH(ret), TCGV_HIGH(ret), 31);
+ tcg_gen_sari_i32(TCGV_HIGH(ret), TCGV_LOW(ret), 31);
}
void tcg_gen_ld16u_i64(TCGv_i64 ret, TCGv_ptr arg2, tcg_target_long offset)
--
2.7.4
- [Qemu-devel] [PULL for-2.8 0/9] tcg updates, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 2/9] target-microblaze: Do not dump cpu state with -d in_asm, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 1/9] target-cris: Do not dump cpu state with -d in_asm, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 4/9] log: Add locking to large logging blocks, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 6/9] target-microblaze: Cleanup dec_mul, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 5/9] tcg: Add tcg_gen_mulsu2_{i32, i64, tl}, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 7/9] MAINTAINERS: Update PPC status and maintainer, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 9/9] tcg: correct 32-bit tcg_gen_ld8s_i64 sign-extension,
Richard Henderson <=
- [Qemu-devel] [PULL for-2.8 8/9] tcg/tcg.h: Improve documentation of TCGv_i32 etc types, Richard Henderson, 2016/10/31
- Re: [Qemu-devel] [PULL for-2.8 0/9] tcg updates, Peter Maydell, 2016/10/31