Re: [Qemu-devel] [PATCH] atapi: classify read_cd as conditionally returning data

[John Snow]

On 10/31/2016 10:06 AM, Kevin Wolf wrote:
> Am 29.10.2016 um 00:32 hat John Snow geschrieben:
> > For the purposes of byte_count_limit verification, add a new flag that
> > identifies read_cd as sometimes returning data, then check the BCL in
> > its command handler after we know that it will indeed return data.
> >
> > Reported-by: Hervé Poussineau <address@hidden>
> > Signed-off-by: John Snow <address@hidden>
>
> Wouldn't it be useful to actually add the new flag to cmd_read_cd then?
> While at it, I would also split the patch into one for adding the flag
> and one for updating cmd_read_cd.

As pointed out by Herve, no -- sorry.

> Also, would it be hard to add a qtest case for this?

I could add it to AHCI pretty easily.

> Kevin