qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL for-2.8 0/9] tcg updates


From: Peter Maydell
Subject: Re: [Qemu-devel] [PULL for-2.8 0/9] tcg updates
Date: Mon, 31 Oct 2016 17:25:30 +0000

On 31 October 2016 at 16:57, Richard Henderson <address@hidden> wrote:
> On 10/31/2016 10:40 AM, Peter Maydell wrote:
>>
>> I'm afraid this doesn't build on w32:
>>
>> In file included from ./trace/generated-tracers.h:5980:0,
>>                  from
>> /home/petmay01/linaro/qemu-for-merges/include/trace.h:4,
>>                  from
>> /home/petmay01/linaro/qemu-for-merges/qapi/qapi-visit-core.c:22:
>> /home/petmay01/linaro/qemu-for-merges/include/qemu/log.h: In function
>> ‘qemu_log_lock’:
>> /home/petmay01/linaro/qemu-for-merges/include/qemu/log.h:62:5: error:
>> implicit declaration of function ‘flockfile’
>> [-Werror=implicit-function-declaration]
>>      flockfile(qemu_logfile);
>>      ^
>
>
> Ho hum.  Mingw seems to have
>
>   _CRTIMP void __cdecl _lock_file(FILE *_File);
>   _CRTIMP void __cdecl _unlock_file(FILE *_File);
>
> for no apparent good reason.

MS names for the functions, I think.

>  Shall I attempt to hide this detail within
> sysemu/os-*?  As qemu_flockfile, presumably?

That would probably be cleanest.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]