[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL for-2.8 0/9] tcg updates
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL for-2.8 0/9] tcg updates |
Date: |
Mon, 31 Oct 2016 17:25:30 +0000 |
On 31 October 2016 at 16:57, Richard Henderson <address@hidden> wrote:
> On 10/31/2016 10:40 AM, Peter Maydell wrote:
>>
>> I'm afraid this doesn't build on w32:
>>
>> In file included from ./trace/generated-tracers.h:5980:0,
>> from
>> /home/petmay01/linaro/qemu-for-merges/include/trace.h:4,
>> from
>> /home/petmay01/linaro/qemu-for-merges/qapi/qapi-visit-core.c:22:
>> /home/petmay01/linaro/qemu-for-merges/include/qemu/log.h: In function
>> ‘qemu_log_lock’:
>> /home/petmay01/linaro/qemu-for-merges/include/qemu/log.h:62:5: error:
>> implicit declaration of function ‘flockfile’
>> [-Werror=implicit-function-declaration]
>> flockfile(qemu_logfile);
>> ^
>
>
> Ho hum. Mingw seems to have
>
> _CRTIMP void __cdecl _lock_file(FILE *_File);
> _CRTIMP void __cdecl _unlock_file(FILE *_File);
>
> for no apparent good reason.
MS names for the functions, I think.
> Shall I attempt to hide this detail within
> sysemu/os-*? As qemu_flockfile, presumably?
That would probably be cleanest.
thanks
-- PMM
- [Qemu-devel] [PULL for-2.8 2/9] target-microblaze: Do not dump cpu state with -d in_asm, (continued)
- [Qemu-devel] [PULL for-2.8 2/9] target-microblaze: Do not dump cpu state with -d in_asm, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 1/9] target-cris: Do not dump cpu state with -d in_asm, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 4/9] log: Add locking to large logging blocks, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 6/9] target-microblaze: Cleanup dec_mul, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 5/9] tcg: Add tcg_gen_mulsu2_{i32, i64, tl}, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 7/9] MAINTAINERS: Update PPC status and maintainer, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 9/9] tcg: correct 32-bit tcg_gen_ld8s_i64 sign-extension, Richard Henderson, 2016/10/31
- [Qemu-devel] [PULL for-2.8 8/9] tcg/tcg.h: Improve documentation of TCGv_i32 etc types, Richard Henderson, 2016/10/31
- Re: [Qemu-devel] [PULL for-2.8 0/9] tcg updates, Peter Maydell, 2016/10/31