Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

[ashish mittal]

Thanks! Will fix these in the next patch!

On Mon, Oct 31, 2016 at 12:05 PM, Eric Blake <address@hidden> wrote:
> On 10/29/2016 01:47 AM, Ashish Mittal wrote:
>> Source code for the qnio library that this code loads can be downloaded from:
>> https://github.com/MittalAshish/libqnio.git
>
> For now, just an interface review:
>
>>
>> Sample command line using the JSON syntax:
>> ./qemu-system-x86_64 -name instance-00000008 -S -vnc 0.0.0.0:0 -k en-us
>> -vga cirrus -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5
>> -msg timestamp=on
>> 'json:{"driver":"vxhs","vdisk_id":"c3e9095a-a5ee-4dce-afeb-2a59fb387410",
>
> This doesn't match the code, which spelled it "vdisk-id".
>
>> "server":{"host":"172.172.17.4","port":"9999"}}'
>>
>> Sample command line using the URI syntax:
>> qemu-img convert -f raw -O raw -n
>> /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad
>> vxhs://192.168.0.1:9999/c6718f6b-0401-441d-a8c3-1f0064d75ee0
>>
>> Signed-off-by: Ashish Mittal <address@hidden>
>> ---
>
>> +++ b/qapi/block-core.json
>> @@ -1704,12 +1704,13 @@
>>  # @host_device, @host_cdrom: Since 2.1
>>  # @gluster: Since 2.7
>>  # @nbd: Since 2.8
>> +# @vxhs: Since 2.8
>
> Please rebase on top of the latest block pull request:
> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg08089.html
>
> In particular, your patch should look something like:
>
> -# @nbd, @nfs, @replication, @ssh: Since 2.8
> +# @nbd, @nfs, @replication, @ssh, @vxhs: Since 2.8
>
>>  #
>>  # Since: 2.0
>>  ##
>>  { 'enum': 'BlockdevDriver',
>>    'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
>> -            'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
>> +            'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', 'vxhs',
>>              'host_device', 'http', 'https', 'luks', 'nbd', 'null-aio',
>>              'null-co', 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw',
>>              'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
>
> Please keep this enum sorted alphabetically (your entry should be after
> vvfat, not in the random middle).
>
>> @@ -2238,6 +2239,20 @@
>>              '*export': 'str',
>>              '*tls-creds': 'str' } }
>>
>> +# @BlockdevOptionsVxHS
>
> Missing a leading ## marker.
>
>> +#
>> +# Driver specific block device options for VxHS
>> +#
>> +# @vdisk-id:    UUID of VxHS volume
>> +#
>> +# @server:      vxhs server IP, port
>> +#
>> +# Since: 2.8
>> +##
>> +{ 'struct': 'BlockdevOptionsVxHS',
>> +  'data': { 'vdisk-id': 'str',
>> +            'server': 'InetSocketAddress' } }
>> +
>>  ##
>>  # @BlockdevOptions
>>  #
>> @@ -2302,7 +2317,8 @@
>>        'vhdx':       'BlockdevOptionsGenericFormat',
>>        'vmdk':       'BlockdevOptionsGenericCOWFormat',
>>        'vpc':        'BlockdevOptionsGenericFormat',
>> -      'vvfat':      'BlockdevOptionsVVFAT'
>> +      'vvfat':      'BlockdevOptionsVVFAT',
>> +      'vxhs':       'BlockdevOptionsVxHS'
>>    } }
>>
>>  ##
>>
>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>