Re: [Qemu-devel] git master build failure (migration/colo.c)

[Jeff Cody]

On Mon, Oct 31, 2016 at 08:08:46PM +0000, Mark Cave-Ayland wrote:
> I've just done a git pull and get the following build error here:
> 
> cc -I/home/build/src/qemu/git/qemu/tcg
> -I/home/build/src/qemu/git/qemu/tcg/i386
> -I/home/build/src/qemu/git/qemu/linux-headers
> -I/home/build/src/qemu/git/qemu/linux-headers -I.
> -I/home/build/src/qemu/git/qemu -I/home/build/src/qemu/git/qemu/include
> -Imigration -Imigration -I/usr/include/pixman-1
> -I/home/build/src/qemu/git/qemu/dtc/libfdt -Werror -pthread
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings
> -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv
> -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs
> -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers
> -Wold-style-declaration -Wold-style-definition -Wtype-limits
> -fstack-protector-all -I/usr/include/p11-kit-1
> -I/usr/include/libpng12   -I/home/build/src/qemu/git/qemu/tests -MMD -MP
> -MT migration/colo-failover.o -MF migration/colo-failover.d -O2
> -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g   -c -o
> migration/colo-failover.o migration/colo-failover.c
> migration/colo.c: In function ‘colo_process_incoming_thread’:
> migration/colo.c:448:9: error: ‘request’ may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
> cc1: all warnings being treated as errors
> make: *** [migration/colo.o] Error 1
> make: *** Waiting for unfinished jobs....
> 
> Does anyone else see this at all?
> 

I'm not seeing it for later gcc versions (6.2.1), but I was able to
reproduce on earlier ones (4.4.7, for instance).  I sent a patch out for
this.


Thanks,
Jeff