Re: [Qemu-devel] [PULL 10/18] COLO: Add checkpoint-delay parameter for migrate-set-parameters

[Hailiang Zhang]

On 2016/11/1 1:17, Juan Quintela wrote:
> Amit Shah <address@hidden> wrote:
> > From: zhanghailiang <address@hidden>
> >
> > Add checkpoint-delay parameter for migrate-set-parameters, so that
> > we can control the checkpoint frequency when COLO is in periodic mode.
> >
> >
> > @@ -587,6 +593,7 @@ MigrationParameters *qmp_query_migrate_parameters(Error 
> > **errp)
> >       params->max_bandwidth = s->parameters.max_bandwidth;
> >       params->has_downtime_limit = true;
> >       params->downtime_limit = s->parameters.downtime_limit;
> > +    params->x_checkpoint_delay = s->parameters.x_checkpoint_delay;
> >
> >       return params;
> >   }
>
> I think you are missing here:
>
> params->has_x_checkpoint_delay = true;

Good catch, this will influence output of
qmp command 'query-migrate-parameters'.
(Without this, 'query-migrate-parameters'
command will shows no "x-checkpoint-delay": 200)

I will send a patch to fix it, thanks very much.

Hailiang

> No?
>
> Later, Juan
>
> .