qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 03/18] migration: Enter into COLO mode after migr


From: Hailiang Zhang
Subject: Re: [Qemu-devel] [PULL 03/18] migration: Enter into COLO mode after migration if COLO is enabled
Date: Tue, 1 Nov 2016 11:39:07 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 2016/11/1 6:27, Eric Blake wrote:
On 10/30/2016 05:46 AM, Amit Shah wrote:
From: zhanghailiang <address@hidden>

Add a new migration state: MIGRATION_STATUS_COLO. Migration source side
enters this state after the first live migration successfully finished
if COLO is enabled by command 'migrate_set_capability x-colo on'.

We reuse migration thread, so the process of checkpointing will be handled
in migration thread.


+++ b/qapi-schema.json
@@ -459,12 +459,14 @@
  #
  # @failed: some error occurred during migration process.
  #
+# @colo: VM is in the process of fault tolerance. (since 2.8)
+#

The commit message mentions it, but the public documentation does not,
so it might be worth a followup patch that clarifies in the schema that
the 'colo' state is not possible without using the 'x-colo' migration
property (so that applications like libvirt know that they don't have to
worry about handling an unexpected state, at least not in 2.8 or until
the 'x-colo' is promoted to plain 'colo').


Sounds reasonable, I'll send a patch to add such clarification.

Thanks,
Hailiang




reply via email to

[Prev in Thread] Current Thread [Next in Thread]