Re: [Qemu-devel] [PATCH v3 2/2] target-m68k: add 680x0 divu/divs variants

[Richard Henderson]

On 10/31/2016 05:48 PM, Laurent Vivier wrote:
> +void HELPER(divull)(CPUM68KState *env, int numr, int regr, uint32_t den)
> +{
> +    uint32_t num = env->dregs[numr];

  uint64_t num = deposit64(env->dregs[numr], 32, 32, env->dregs[regr]);

Similarly in divsll with int64_t num.

> +    if (!((quot >> 31) == 0 || (quot >> 31) == -1)) {

Maybe better as

  if (quot != (int32_t)quot)

as in divsw.

Otherwise it looks good.


r~