Re: [Qemu-devel] [PULL v2 00/14] Block patches for 2.8

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL v2 00/14] Block patches for 2.8
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8e6d375 blockjobs: fix documentation
7142def blockjobs: split interface into public/private, Part 1
f8a014f Blockjobs: Internalize user_pause logic
3d3f46f blockjob: centralize QMP event emissions
ae0da88 Replication/Blockjobs: Create replication jobs as internal
be4560c blockjobs: Allow creating internal jobs
1da36d3 blockjobs: hide internal jobs from management API
1a65ed4 block/gluster: fix port type in the QAPI options list
718812b block/gluster: improve defense over string to int conversion
11dc993 block: Turn on "unmap" in active commit
5baafb5 block/gluster: memory usage: use one glfs instance per volume
63ea898 block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support
9c11fb6 rbd: make the code more readable
8af9516 qapi: add release designator to gluster logfile option

=== OUTPUT BEGIN ===
fatal: unrecognized argument: --no-patch
Checking PATCH 1/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 2/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 3/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 4/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 5/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 6/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 7/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 8/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 9/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 10/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 11/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 12/14: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 13/14: ...
ERROR: struct BlockJobDriver should normally be const
#193: FILE: include/block/blockjob.h:31:
+typedef struct BlockJobDriver BlockJobDriver;

ERROR: struct BlockJobDriver should normally be const
#433: FILE: include/block/blockjob_int.h:37:
+struct BlockJobDriver {

ERROR: space prohibited between function name and open parenthesis '('
#477: FILE: include/block/blockjob_int.h:81:
+    void coroutine_fn (*pause)(BlockJob *job);

ERROR: space prohibited between function name and open parenthesis '('
#484: FILE: include/block/blockjob_int.h:88:
+    void coroutine_fn (*resume)(BlockJob *job);

total: 4 errors, 0 warnings, 578 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

fatal: unrecognized argument: --no-patch
Checking PATCH 14/14: ...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden