[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 30/30] main-loop: Suppress I/O thread warning under q
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 30/30] main-loop: Suppress I/O thread warning under qtest |
Date: |
Tue, 1 Nov 2016 17:29:43 +0100 |
From: Max Reitz <address@hidden>
We do not want to display the "I/O thread spun" warning for test cases
that run under qtest. The first attempt for this (commit
01c22f2cdd4fcf02276ea10f48253850a5fd7259) tested whether qtest_enabled()
was true.
Commit 21a24302e85024dd7b2a151158adbc1f5dc5c4dd correctly recognized
that just testing qtest_enabled() is not sufficient since there are some
tests that do not use the qtest accelerator but just the qtest character
device, and thus replaced qtest_enabled() by qtest_driver().
However, there are also some tests that only use the qtest accelerator
and not the qtest chardev; perhaps most notably the bash iotests.
Therefore, we have to check both qtest_enabled() and qtest_driver().
Signed-off-by: Max Reitz <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
main-loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main-loop.c b/main-loop.c
index 66c4eb6..ad10bca 100644
--- a/main-loop.c
+++ b/main-loop.c
@@ -234,7 +234,7 @@ static int os_host_main_loop_wait(int64_t timeout)
if (!timeout && (spin_counter > MAX_MAIN_LOOP_SPIN)) {
static bool notified;
- if (!notified && !qtest_driver()) {
+ if (!notified && !qtest_enabled() && !qtest_driver()) {
fprintf(stderr,
"main-loop: WARNING: I/O thread spun for %d iterations\n",
MAX_MAIN_LOOP_SPIN);
--
2.7.4
- [Qemu-devel] [PULL 19/30] nbd: Support shorter handshake, (continued)
- [Qemu-devel] [PULL 19/30] nbd: Support shorter handshake, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 20/30] nbd: Refactor conversion to errno to silence checkpatch, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 21/30] nbd: Improve server handling of shutdown requests, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 22/30] nbd: Implement NBD_CMD_WRITE_ZEROES on server, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 23/30] nbd: Implement NBD_CMD_WRITE_ZEROES on client, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 24/30] qemu-char: do not forward events through the mux until QEMU has started, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 26/30] x86: add AVX512_4VNNIW and AVX512_4FMAPS features, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 25/30] slirp: fix CharDriver breakage, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 28/30] vl: exit qemu on guest panic if -no-shutdown is not set, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 27/30] checkpatch: allow spaces before parenthesis for 'coroutine_fn', Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 30/30] main-loop: Suppress I/O thread warning under qtest,
Paolo Bonzini <=
- [Qemu-devel] [PULL 29/30] docs/rcu.txt: Fix minor typo, Paolo Bonzini, 2016/11/01
- Re: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31, no-reply, 2016/11/01
- Re: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31, Peter Maydell, 2016/11/01