qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enable


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field
Date: Tue, 1 Nov 2016 15:02:31 -0200
User-agent: Mutt/1.7.0 (2016-08-17)

On Tue, Nov 01, 2016 at 04:43:11PM +0000, Wei Liu wrote:
[...]
> @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, int 
> running,
>  
>  static int xen_init(MachineState *ms)
>  {
> +    PCMachineState *pcms = PC_MACHINE(ms);
> +
> +    /* Disable ACPI build because Xen handles it */
> +    pcms->acpi_build_enabled = false;

I just noticed that I don't see any code to disable ACPI build in
the case of "-machine pc,accel=xen". I suggest a xen_enabled()
check in pc_init1() and pc_q35_init().

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]