Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

[Wei Liu]

On Tue, Nov 01, 2016 at 03:02:31PM -0200, Eduardo Habkost wrote:
> On Tue, Nov 01, 2016 at 04:43:11PM +0000, Wei Liu wrote:
> [...]
> > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, int 
> > running,
> >  
> >  static int xen_init(MachineState *ms)
> >  {
> > +    PCMachineState *pcms = PC_MACHINE(ms);
> > +
> > +    /* Disable ACPI build because Xen handles it */
> > +    pcms->acpi_build_enabled = false;
> 
> I just noticed that I don't see any code to disable ACPI build in
> the case of "-machine pc,accel=xen". I suggest a xen_enabled()

Hmm... I think this code snippet does exactly that -- xen_init is the
initialization function for Xen accelerator. So this covers -m xenfv
(because it sets accelerator to xen) and -m whatever,accel=xen.

Did I miss anything?

Wei.