Re: [Qemu-devel] [PATCH] migration: fix missing assignment for has_x_checkpoint_delay

[Hailiang Zhang]

On 2016/11/1 22:27, Eric Blake wrote:
> On 11/01/2016 12:50 AM, zhanghailiang wrote:
> > We forgot to assign true to params->has_x_checkpoint_delay parameter
> > in qmp_query_migrate_parameters.
> >
> > Without this, qmp command 'query-migrate-parameters' doesn't show the
> > default value for x-checkpoint-delay option.
> > It doesn't influence output of hmp command 'info migrate_parameters'.
>
> Well, only because the current code doesn't forcefully assign missing
> optional parameters to any other value.  But HMP was relying on
> unspecified behavior, that could have broken with any other qapi change.
>
> I might word the commit message:
>
> This also fixes the fact that HMP was relying on unspecified behavior by
> reading x_checkpoint_delay without checking has_x_checkpoint_delay.
>
> Up to the maintainer, though, since the patch itself is fine.

OK, thanks, I'd like to fix the message as your said :)

> > Signed-off-by: zhanghailiang <address@hidden>
> > ---
> >   hmp.c                 | 1 +
> >   migration/migration.c | 1 +
> >   2 files changed, 2 insertions(+)
>
> Reviewed-by: Eric Blake <address@hidden>