[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS bloc
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support |
Date: |
Wed, 2 Nov 2016 10:57:38 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 01.11.2016 um 05:03 hat ashish mittal geschrieben:
> >> >> +##
> >> >> +{ 'struct': 'BlockdevOptionsVxHS',
> >> >> + 'data': { 'vdisk_id': 'str',
> >> >> + 'server': 'InetSocketAddress' } }
> >> >
> >> > Is there any way to use a Unix socket, or is this server ONLY accessible
> >> > over IPv4/IPv6?
> >> >
> >>
> >> Right now we support IPv4 only.
> >
> > IMHO it should allow use of UNIX sockets, as its possible to have
> > SSH setup a tunnel to a IP server, and expose the endpoint via a
> > UNIX socket. So even if your reference server only supports IPv4,
> > users can conceivably connect with any sockets protocol.
> >
>
> This is not a use-case that we have in mind right now, but a very fair
> point! Kind of like accessing the audio/video streams remotely from my
> Raspberry Pi over ssh. Is it OK if we target this in a future patch
> after proper review/testing?
No, going from InetSocketAddress to SocketAddress changes the API in an
incompatible way (previously working blockdev-add commands would stop
working), so we must decide now before the API is introduced.
Kevin