Re: [Qemu-devel] [PATCH v1 1/1] qemu-doc: update gluster protocol usage guide

[Prasanna Kalever]

On Tue, Nov 1, 2016 at 11:32 PM, Eric Blake <address@hidden> wrote:
> On 11/01/2016 07:29 AM, Prasanna Kumar Kalever wrote:
>> Document:
>> 1. The new debug and logfile options with their usages and
>> 2. New json format and its usage.
>>
>> Signed-off-by: Prasanna Kumar Kalever <address@hidden>
>> ---
>>  qemu-doc.texi   | 46 ++++++++++++++++++++++++++++++++--------------
>>  qemu-options.hx | 14 ++++++++++++--
>>  2 files changed, 44 insertions(+), 16 deletions(-)
>>
>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>> index 023c140..a7c5722 100644
>> --- a/qemu-doc.texi
>> +++ b/qemu-doc.texi
>> @@ -1041,35 +1041,50 @@ GlusterFS is an user space distributed file system.
>>
>>  You can boot from the GlusterFS disk image with the command:
>>  @example
>> -qemu-system-x86_64 -drive 
>> address@hidden://address@hidden:@var{port}]]/@var{volname}/@var{image}[?socket=...]
>> +URI:
>> +qemu-system-x86_64 -drive 
>> address@hidden://address@hidden:@var{port}]]/@var{volume}/@var{path}[?socket=...]
>> +
>> +JSON:
>> +qemu-system-x86_64 
>> 'json:@{"driver":"qcow2","file":@{"driver":"gluster","volume":"testvol","path":"a.img","debug":"N","logfile":"...","server":address@hidden"type":"tcp","host":"...","port":"..."@},@{"type":"unix","socket":"..."@address@hidden@}'
>
> "debug":"N" does not match the schema; the parameter is named
> "debug-level", and it is an integer not a string.  The parameter is
> optional; you could just omit it. But if you are going to include it,
> give a reasonable example like "debug-level":0.

Eric,

>From the code I can see
#define GLUSTER_OPT_DEBUG           "debug"

And even tried this, there is no option 'debug-level'.
And yes, I should admit it is 'int' not a 'string'

Thanks, rest of the comments seems convincing to me, will make the
changes and spin them soon.

--
Prasanna

[...]
>>
>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>