Re: [Qemu-devel] [PATCH v3 0/4] nvdimm: hotplug support

[Igor Mammedov]

On Sat, 29 Oct 2016 00:35:36 +0800
Xiao Guangrong <address@hidden> wrote:

> It is based on my previous patchset,
> "[PATCH 0/8] nvdimm acpi: bug fix and cleanup", these two patchset are
> against commit dea651a95af6dad099 (intel-iommu: Check IOAPIC's Trigger Mode
> against the one in IRTE) on pci branch of Michael's git tree and can be
> found at:
>       https://github.com/xiaogr/qemu.git nvdimm-hotplug-v3
> 
> Changelog in v3:
>    1) use a dedicated interrupt for nvdimm device hotplug
>    2) stop nvdimm device hot unplug
>    3) reserve UUID and handle for QEMU internally used QEMU
>    5) redesign fit buffer to avoid OSPM reading incomplete fit info
>    6) bug fixes and cleanups
> 
> Changelog in v2:
>    Fixed signed integer overflow pointed out by Stefan Hajnoczi
> 
> This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug,
> for example, a new nvdimm device can be plugged as follows:
> object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3
> device_add nvdimm,id=nvdimm3,memdev=mem3
> 
> and unplug it as follows:
> device_del nvdimm3
> object_del mem3
there is no unplug support


instead of incremental fixups on top merged patches in followup series,
I'd prefer it to make a clean revert for patches 2-4/4  first and
them amended versions of them to follow.

> 
> Xiao Guangrong (4):
>   nvdimm acpi: prebuild nvdimm devices for available slots
>   nvdimm acpi: introduce fit buffer
>   nvdimm acpi: introduce _FIT
>   pc: memhp: enable nvdimm device hotplug
> 
>  docs/specs/acpi_mem_hotplug.txt      |   3 +
>  docs/specs/acpi_nvdimm.txt           |  58 ++++++-
>  hw/acpi/memory_hotplug.c             |  31 +++-
>  hw/acpi/nvdimm.c                     | 286 
> +++++++++++++++++++++++++++++++----
>  hw/core/hotplug.c                    |  11 ++
>  hw/core/qdev.c                       |  20 ++-
>  hw/i386/acpi-build.c                 |   9 +-
>  hw/i386/pc.c                         |  31 ++++
>  hw/mem/nvdimm.c                      |   4 -
>  include/hw/acpi/acpi_dev_interface.h |   1 +
>  include/hw/hotplug.h                 |  10 ++
>  include/hw/mem/nvdimm.h              |  27 +++-
>  12 files changed, 443 insertions(+), 48 deletions(-)
>