Re: [Qemu-devel] [PATCH v3 3/4] nvdimm acpi: introduce _FIT

[Xiao Guangrong]

On 11/02/2016 12:41 AM, Stefan Hajnoczi wrote:
> On Sat, Oct 29, 2016 at 12:35:39AM +0800, Xiao Guangrong wrote:
> > +1) Read FIT
> > +   As we only reserved one page for NVDIMM ACPI it is impossible to map the
> > +   whole FIT data to guest's address space. This function is used by _FIT
> > +   method to read a piece of FIT data from QEMU.
> > +
> > +   Input parameters:
> > +   Arg0 – UUID {set to 648B9CF2-CDA1-4312-8AD9-49C4AF32BD62}
> > +   Arg1 – Revision ID (set to 1)
> > +   Arg2 - Function Index, 0x1
> > +   Arg3 - A package containing a buffer whose layout is as follows:
> > +
> > +   +----------+-------------+-------------+-----------------------------------+
> > +   |  Filed   | Byte Length | Byte Offset | Description                       |
>
> s/Filed/Field/
>
> The same applies below too.

Will fix.

> > +   +----------+-------------+-------------+-----------------------------------+
> > +   | offset   |     4       |    0        | the offset of FIT buffer          |
> > +   +----------+-------------+-------------+-----------------------------------+
>
> s/offset of FIT buffer/offset into FIT buffer/

will fix.

> > +
> > +   Output:
> > +   +----------+-------------+-------------+-----------------------------------+
> > +   |  Filed   | Byte Length | Byte Offset | Description                       |
> > +   +----------+-------------+-------------+-----------------------------------+
> > +   |          |             |             | return status codes               |
> > +   |          |             |             |   0x100 indicates fit has been    |
> > +   | status   |     4       |    0        |   updated                         |
> > +   |          |             |             | other follows Chapter 3 in DSM    |
> > +   |          |             |             | Spec Rev1                         |
> > +   +----------+-------------+-------------+-----------------------------------+
> > +   | fit data |  Varies     |    4        | FIT data                          |
> > +   |          |             |             |                                   |
> > +   +----------+-------------+-------------+-----------------------------------+
> > +
> > +   The FIT offset is maintained by the caller itself, current offset plugs
>
> s/plugs/plus/

Yes, indeed.

> > +struct NvdimmFuncReadFITIn {
> > +    uint32_t offset; /* the offset of FIT buffer. */
>
> s/offset of FIT buffer/offset into FIT buffer/

will fix.

Thank you, Stefan!