Re: [Qemu-devel] [PULL 0/2] M68k for 2.8 patches

[Stefan Hajnoczi]

On Wed, Nov 2, 2016 at 5:17 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Wed, Nov 2, 2016 at 5:12 PM, Laurent Vivier <address@hidden> wrote:
>> Le 02/11/2016 à 18:07, Stefan Hajnoczi a écrit :
>>> On Mon, Oct 31, 2016 at 10:50:29AM +0100, Laurent Vivier wrote:
>>>> The following changes since commit 
>>>> 5b2ecabaeabc17f032197246c4846b9ba95ba8a6:
>>>>
>>>>   Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' 
>>>> into staging (2016-10-28 17:59:04 +0100)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>   address@hidden:vivier/qemu-m68k.git tags/m68k-for-2.8-pull-request
>>>
>>> This URI is not publicly accessible.  Some tools will fail to apply your
>>> pull request because of this.
>>>
>>> Please adjust your .gitconfig:
>>>
>>> [remote "origin"]
>>>     url = git://github.com/vivier/qemu.git
>>>     pushurl = address@hidden:vivier/qemu.git
>>
>> Thank you Stefan.
>>
>> I'm using your tool "git-publish", is there a way to detect this problem
>> automatically?
>
> Right now git-publish doesn't check the generated URI.  In some use
> cases it's reasonable to use an SSH URI so adding an error or even
> warning to git-publish isn't ideal.
>
> I am modifying the patches tool (https://github.com/stefanha/patches)
> to automatically translate GitHub URIs since they are so prevalent...
> This will allow me to apply pull requests that have GitHub SSH URIs.

On second thought, even that isn't a general solution.  If people are
collaborating on private GitHub repos then translating URIs to HTTPS
is not correct either.

Instead of trying to do magic I'll ask pull request submitters to fix
their .gitconfig.

Stefan