[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT |
Date: |
Thu, 3 Nov 2016 09:53:53 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote:
> @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr
> dsm_mem_addr)
> cpu_physical_memory_write(dsm_mem_addr, &out, sizeof(out));
> }
>
> +#define NVDIMM_DSM_RET_STATUS_SUCCESS 0 /* Success */
> +#define NVDIMM_DSM_RET_STATUS_UNSUPPORT 1 /* Not Supported */
> +#define NVDIMM_DSM_RET_STATUS_INVALID 3 /* Invalid Input Parameters */
Not worth changing but please make each logical change a separate patch
in the future. This patch is cluttered with NVDIMM_DSM_RET_STATUS_
constant renaming. It's easier to review, bisect, and backport when
structured as separate patches.
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v4 0/3] nvdimm: hotplug support, Xiao Guangrong, 2016/11/03
- [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT, Xiao Guangrong, 2016/11/03
- Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT, Igor Mammedov, 2016/11/03
- Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT, Xiao Guangrong, 2016/11/03
- Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT, Igor Mammedov, 2016/11/03
- Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT, Xiao Guangrong, 2016/11/03
- Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT, Igor Mammedov, 2016/11/03
- Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT, Xiao Guangrong, 2016/11/03
- Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT, Igor Mammedov, 2016/11/03
- Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT, Xiao Guangrong, 2016/11/03