[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] virtio: rename virtqueue_discard to virt
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] virtio: rename virtqueue_discard to virtqueue_unpop |
|
Date: |
Fri, 4 Nov 2016 09:28:39 +0100 |
On Fri, 4 Nov 2016 07:19:16 +0100
Ladi Prosek <address@hidden> wrote:
> On Fri, Nov 4, 2016 at 3:42 AM, Alexey Kardashevskiy <address@hidden> wrote:
> > On 03/11/16 19:55, Ladi Prosek wrote:
> >> The function undoes the effect of virtqueue_pop and doesn't do anything
> >> destructive or irreversible so virtqueue_unpop is a more fitting name.
> >
> > virtqueue_undo_pop() is even better, it was suggested by native english
> > speaker (i.e. not myself) :)
>
> virtqueue_undo_pop sounds good too, I have no preference between the
> two really :) Thanks!
If you need a tie breaker: I like virtqueue_undo_pop() better :)