Re: [Qemu-devel] [PATCH 1/3] vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout

[Greg Kurz]

On Fri, 4 Nov 2016 10:38:32 +0100
Cornelia Huck <address@hidden> wrote:

> On Fri, 04 Nov 2016 09:39:15 +0100
> Greg Kurz <address@hidden> wrote:
> 
> > With virtio 1, the vring layout is split in 3 separate regions of
> > contiguous memory for the descriptor table, the available ring and the
> > used ring, as opposed with legacy virtio which uses a single region.
> > 
> > In case of memory re-mapping, the code ensures it doesn't affect the
> > vring mapping. This is done in vhost_verify_ring_mappings() which assumes
> > the device is legacy.
> > 
> > This patch changes vhost_verify_ring_mappings() to check the mappings of
> > each part of the vring separately.  
> 
> Add "This will work for legacy mappings as well." ?
> 

Sure!

> > 
> > Signed-off-by: Greg Kurz <address@hidden>
> > ---
> >  hw/virtio/vhost.c         |   79 
> > ++++++++++++++++++++++++++++++++++-----------
> >  include/hw/virtio/vhost.h |    4 ++
> >  2 files changed, 64 insertions(+), 19 deletions(-)  
> 
> Reviewed-by: Cornelia Huck <address@hidden>
>