Re: [Qemu-devel] [RFC 06/17] ppc: Rename cpu_version to compat_pvr

[Thomas Huth]

On 30.10.2016 12:11, David Gibson wrote:
> The 'cpu_version' field in PowerPCCPU is badly named.  It's named after the
> 'cpu-version' device tree property where it is advertised, but that meaning
> may not be obvious in most places it appears.
> 
> Worse, it doesn't even really correspond to that device tree property.  The
> property contains either the processor's PVR, or, if the CPU is running in
> a compatibility mode, a special "logical PVR" representing which mode.
> 
> Rename the cpu_version field, and a number of related variables to
> compat_pvr to make this clearer.
> 
> Signed-off-by: David Gibson <address@hidden>
> ---
>  hw/ppc/spapr.c              |  4 ++--
>  hw/ppc/spapr_hcall.c        | 30 +++++++++++++++---------------
>  target-ppc/cpu.h            |  6 +++---
>  target-ppc/kvm.c            |  4 ++--
>  target-ppc/kvm_ppc.h        |  4 ++--
>  target-ppc/translate_init.c | 10 +++++-----
>  6 files changed, 29 insertions(+), 29 deletions(-)

Reviewed-by: Thomas Huth <address@hidden>