|
From: | Markus Armbruster |
Subject: | Re: [Qemu-devel] [PATCH v4 1/8] tests: check-qom-proplist: Remove duplicate "bv" property |
Date: | Fri, 04 Nov 2016 16:10:27 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Markus Armbruster <address@hidden> writes: > Eduardo Habkost <address@hidden> writes: > >> The object_property_add_bool() call in dummy_init() is always >> failing because there is an existing "bv" class property. We need >> to remove either the "bv" class property or the "bv" instance >> property. >> >> Remove the class property so both object properties and class >> properties are covered by the test code. >> >> Reviewed-by: Igor Mammedov <address@hidden> >> Signed-off-by: Eduardo Habkost <address@hidden> > > I accidentally reviewed an older version of this patch. Just in case: > Reviewed-by: Markus Armbruster <address@hidden> > > The multiple colons in the subject are a bit odd. Suggest > "tests/check-qom-proplist:". One more thing: you could test that adding a duplicate property fails.
[Prev in Thread] | Current Thread | [Next in Thread] |