Re: [Qemu-devel] [PATCH 4/4] q35: introduce q35-lite

[Michael S. Tsirkin]

On Sat, Nov 05, 2016 at 03:19:51AM -0400, Chao Peng wrote:
> This patch introduces a light weight machine type which shares the
> same codebase with existing q35 machine type but with some features
> disabled by default.
> 
> Signed-off-by: Chao Peng <address@hidden>

I don't find this too useful, but if others do and send acks, I'll merge
it, but only if it also has migration disabled.

> ---
>  hw/i386/pc_q35.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index d042fe0..1c6b476 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -276,6 +276,15 @@ static void pc_q35_init(MachineState *machine)
>      }
>  }
>  
> +static void pc_q35_lite_init(MachineState *machine)
> +{
> +    PCMachineState *pcms = PC_MACHINE(machine);
> +
> +    pcms->smbus = false;
> +    pcms->sata = false;
> +    pcms->pit = false;
> +}
> +
>  #define DEFINE_Q35_MACHINE(suffix, name, compatfn, optionfn) \
>      static void pc_init_##suffix(MachineState *machine) \
>      { \
> @@ -301,6 +310,15 @@ static void pc_q35_machine_options(MachineClass *m)
>      m->max_cpus = 288;
>  }
>  
> +static void pc_q35_lite_machine_options(MachineClass *m)
> +{
> +    pc_q35_machine_options(m);
> +    m->alias = "q35-lite";
> +}
> +
> +DEFINE_Q35_MACHINE(lite, "pc-q35-lite", pc_q35_lite_init,
> +                   pc_q35_lite_machine_options);
> +
>  static void pc_q35_2_8_machine_options(MachineClass *m)
>  {
>      pc_q35_machine_options(m);
> -- 
> 1.8.3.1