Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

[Peter Maydell]

On 7 November 2016 at 13:38, Michal Suchanek <address@hidden> wrote:
> ncurses version in SUSE does not have .pc files so this is still needed to
> build from git.
>
> Signed-off-by: Michal Suchanek <address@hidden>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index fd6f898..aab70ef 100755
> --- a/configure
> +++ b/configure
> @@ -2926,7 +2926,7 @@ if test "$curses" != "no" ; then
>      curses_inc_list="$($pkg_config --cflags ncurses 2>/dev/null):"
>      curses_lib_list="$($pkg_config --libs ncurses 2>/dev/null):-lpdcurses"
>    else
> -    curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):"
> +    curses_inc_list="$($pkg_config --cflags ncursesw 
> 2>/dev/null)-I/usr/include/ncursesw:"
>      curses_lib_list="$($pkg_config --libs ncursesw 
> 2>/dev/null):-lncursesw:-lcursesw"

I think this will produce malformed output on platforms where
pkg-config does output something useful:
-D_GNU_SOURCE -I/usr/include/ncursesw-I/usr/include/ncursesw:

because there's no colon after the ')'.

In fact this code looks kind of dubious in general, because
it seems to assume that the output of pkg_config never has
a ':' in it...

thanks
-- PMM