[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH Risu v2 0/9] Risu support for PPC64LE
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH Risu v2 0/9] Risu support for PPC64LE |
Date: |
Mon, 7 Nov 2016 16:43:38 +0000 |
On 6 November 2016 at 17:15, Jose Ricardo Ziviani
<address@hidden> wrote:
> v2:
> - smaller commits
> - improved registers comparison
> - improved code style
> - fixed copyright lines
>
> TODOs:
> - improve load/store instruction generation (risugen)
> - improve initial random values for FP and Vector regs (risugen)
> - make write_test_code() generic (risugen)
The files risu_reginfo_ppc64le.h and ppc64.risu both still
claim to be copyright Linaro Limited. Please can you confirm that
I should change those to read 'Copyright (c) IBM Corp, 2016'
like the other new files you have written?
I've also written a trivial fix which uses 'sort keys %insn_details'
rather than just 'keys %insn_details' so that the output binary
remains the same if you run risugen twice with the same arguments;
I then had to propagate that fix to the new places where that
code got copied.
It would be good to have a 'utils' module which gets used
by the arch specific modules so we can avoid having duplicate
functions between all the arch specific modules, but we can
do that as a separate cleanup after this lot.
If you give me the OK to fix up the copyright lines I can push
this patchset to risu master.
thanks
-- PMM
- [Qemu-devel] [PATCH Risu v2 0/9] Risu support for PPC64LE, Jose Ricardo Ziviani, 2016/11/06
- [Qemu-devel] [PATCH Risu v2 3/9] Change mode directive of ARM risu files, Jose Ricardo Ziviani, 2016/11/06
- [Qemu-devel] [PATCH Risu v2 1/9] Create risugen_arm.pm module for risugen, Jose Ricardo Ziviani, 2016/11/06
- [Qemu-devel] [PATCH Risu v2 2/9] Refactor risugen to remove ARM specific code, Jose Ricardo Ziviani, 2016/11/06
- [Qemu-devel] [PATCH Risu v2 4/9] Implement lib to deal with PPC64 registers, Jose Ricardo Ziviani, 2016/11/06
- [Qemu-devel] [PATCH Risu v2 5/9] Implement basic test code for PPC64, Jose Ricardo Ziviani, 2016/11/06
- [Qemu-devel] [PATCH Risu v2 6/9] Implement initial support for PPC64, Jose Ricardo Ziviani, 2016/11/06
- [Qemu-devel] [PATCH Risu v2 8/9] Implement risugen module for PPC64, Jose Ricardo Ziviani, 2016/11/06
- [Qemu-devel] [PATCH Risu v2 7/9] Add PPC64 in risu build system, Jose Ricardo Ziviani, 2016/11/06
- [Qemu-devel] [PATCH Risu v2 9/9] Implement risufile with all PPC64 instructions, Jose Ricardo Ziviani, 2016/11/06
- Re: [Qemu-devel] [PATCH Risu v2 0/9] Risu support for PPC64LE,
Peter Maydell <=