Re: [Qemu-devel] [PATCH 8/8] slirp: VMStatify remaining except for loop

[Dr. David Alan Gilbert]

* Samuel Thibault (address@hidden) wrote:
> Hello,
> 
> Dr. David Alan Gilbert (git), on Thu 27 Oct 2016 16:32:17 +0100, wrote:
> > This converts the remaining components, except for the loop, to VMState.
> > 
> > +        /* TODO: Add loop */
> > +        VMSTATE_UINT16_V(ip_id, Slirp, 2),
> > +        VMSTATE_STRUCT_ARRAY(bootp_clients, Slirp, NB_BOOTP_CLIENTS, 3,
> > +                             vmstate_slirp_bootp_client, BOOTPClient),
> 
> I don't understand: doesn't the NB_BOOTP_CLIENTS parameter here
> implement the loop?

That implements one loop; the TODO is to add the loop over slirp->exec_list
that's at the top of slirp_state_save;  once we find a way of adding that
loop then the whole of slirp_state_save/load disappears and we're left
with just the VMStateDescription.

Dave

> Samuel
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK