[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] target-m68k: add abcd/sbcd/nbcd
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] target-m68k: add abcd/sbcd/nbcd |
|
Date: |
Tue, 8 Nov 2016 11:21:08 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
Le 08/11/2016 à 11:11, Richard Henderson a écrit :
> On 11/07/2016 06:59 PM, Laurent Vivier wrote:
>> + tcg_gen_movi_i32(QREG_CC_X, 0);
>> + tcg_gen_andi_i32(val, val, 0x100);
>> + tcg_gen_setcond_i32(TCG_COND_NE, QREG_CC_C, val, QREG_CC_X);
>
> This is
>
> tcg_gen_shri_i32(QREG_CC_C, val, 8);
> tcg_gen_andi_i32(QREG_CC_C, QREG_CC_C, 1);
Yes, this looks better...
> Otherwise,
>
> Reviewed-by: Richard Henderson <address@hidden>
I fix that and move this patch to my branch m68k-for-2.9
Thanks,
Laurent