Re: [Qemu-devel] [PATCH] hw/input/hid: support alternative sysrq/break scancodes for gtk-vnc

[Gerd Hoffmann]

  Hi,

> Now, it isn't obvious to me which sequence is really "right", but as the
> 0x54/0xc6 keycodes are currently unused in hid.c, supporting both seems like
> the pragmatic solution to me.  The USB HID keyboard boot protocol used by
> hid.c doesn't have any other mapping applicable to these keys.
> 
> The other guest keyboard interfaces (ps/2, virtio, ..) are not affected,
> because they handle these keys differently.

A better fix would be to switch hid.c to use Q_KEY_CODE_* too.
Patches doing that are welcome.  It's a big change though and not
reasonable to do during the freeze, so I'll go pick up this two-line fix
for 2.8 nevertheless.

thanks,
  Gerd