qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/14] nvdimm acpi: cleanup nvdimm_build_fit


From: Igor Mammedov
Subject: Re: [Qemu-devel] [PATCH 08/14] nvdimm acpi: cleanup nvdimm_build_fit
Date: Wed, 9 Nov 2016 17:40:05 +0100

On Mon,  7 Nov 2016 19:13:43 +0800
Xiao Guangrong <address@hidden> wrote:

> inline buf_size to refine the code a bit
> 
> Suggested-by: Igor Mammedov <address@hidden>
> Signed-off-by: Xiao Guangrong <address@hidden>
> ---
>  hw/acpi/nvdimm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Igor Mammedov <address@hidden>

> 
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> index f2c0659..148999e 100644
> --- a/hw/acpi/nvdimm.c
> +++ b/hw/acpi/nvdimm.c
> @@ -1134,11 +1134,9 @@ static void nvdimm_build_fit(Aml *dev)
>      aml_append(ifctx, aml_return(aml_buffer(0, NULL)));
>      aml_append(method, ifctx);
>  
> -    aml_append(method, aml_store(aml_shiftleft(buf_size, aml_int(3)),
> -                                 buf_size));
>      aml_append(method, aml_create_field(buf,
>                              aml_int(4 * BITS_PER_BYTE), /* offset at byte 
> 4.*/
> -                            buf_size, "BUFF"));
> +                            aml_shiftleft(buf_size, aml_int(3)), "BUFF"));
>      aml_append(method, aml_return(aml_name("BUFF")));
>      aml_append(dev, method);
>  




reply via email to

[Prev in Thread] Current Thread [Next in Thread]