qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value


From: Gonglei (Arei)
Subject: Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value
Date: Thu, 10 Nov 2016 05:56:02 +0000

Any ideas about this fix?


Regards,
-Gonglei


> -----Original Message-----
> From: Qemu-devel
> [mailto:address@hidden On
> Behalf Of P J P
> Sent: Wednesday, October 12, 2016 8:38 PM
> To: Qemu Developers
> Cc: Paolo Bonzini; Huawei PSIRT; Prasad J Pandit; Michael S. Tsirkin
> Subject: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value
> 
> From: Prasad J Pandit <address@hidden>
> 
> The JAZZ RC4030 chipset emulator has a periodic timer and
> associated interval reload register. The reload value is used
> as divider when computing timer's next tick value. If reload
> value is large, it could lead to divide by zero error. Limit
> the interval reload value to avoid it.
> 
> Reported-by: Huawei PSIRT <address@hidden>
> Signed-off-by: Prasad J Pandit <address@hidden>
> ---
>  hw/dma/rc4030.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c
> index 2f2576f..c1b4997 100644
> --- a/hw/dma/rc4030.c
> +++ b/hw/dma/rc4030.c
> @@ -460,7 +460,7 @@ static void rc4030_write(void *opaque, hwaddr addr,
> uint64_t data,
>          break;
>      /* Interval timer reload */
>      case 0x0228:
> -        s->itr = val;
> +        s->itr = val & 0x01FF;
>          qemu_irq_lower(s->timer_irq);
>          set_next_tick(s);
>          break;
> --
> 2.5.5
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]