Re: [Qemu-devel] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

[Eric Blake]

On 11/10/2016 11:19 AM, Kevin Wolf wrote:
> Replacing it with bdrv_co_pwritev() prepares us for byte granularity
> requests and gets us rid of the last bdrv_aio_*() user in quorum.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/quorum.c | 52 +++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 33 insertions(+), 19 deletions(-)
> 
> diff --git a/block/quorum.c b/block/quorum.c
> index b2bb3af..1426115 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -134,6 +134,11 @@ struct QuorumAIOCB {
>      int children_read;          /* how many children have been read from */
>  };
>  
> +typedef struct QuorumCo {
> +    QuorumAIOCB *acb;
> +    int i;
> +} QuorumCo;
> +

> @@ -586,11 +605,6 @@ free_exit:
>      return rewrite;
>  }
>  
> -typedef struct QuorumCo {
> -    QuorumAIOCB *acb;
> -    int i;
> -} QuorumCo;

Code motion of a struct added earlier in this series; do you want to
declare it up front to begin with to minimize churn?


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature