[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [kvm-unit-tests PATCH v5 06/11] arm/arm64: add initial
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [kvm-unit-tests PATCH v5 06/11] arm/arm64: add initial gicv2 support |
Date: |
Fri, 11 Nov 2016 16:30:56 +0100 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Fri, Nov 11, 2016 at 03:17:25PM +0000, Andre Przywara wrote:
> >
> > This doesn't seem to be used and I'm not sure what GICD_TYPER_IRQS it is
> > trying to achieve.
>
> The idea is to calculate the number of implemented SPIs. But I am not a
> big fan of copying a macro from the emulation code base to the test code.
>
Consider it rewritten then :-) I did review the spec while copying
over stuff from Linux, so Linux has been getting a review at the
same time. I agree that we should be cautious with copy+paste and
we should probably not bring over super complex macros that are hard
to understand, because we want kvm-unit-tests to be easy to read.
Let's not say "no macros from Linux", but rather case-by-case it.
I think this macro is a nice addition to our little API.
Thanks,
drew
- [Qemu-devel] [kvm-unit-tests PATCH v5 00/11] arm/arm64: add gic framework, Andrew Jones, 2016/11/10
- [Qemu-devel] [kvm-unit-tests PATCH v5 01/11] lib: xstr: allow multiple args, Andrew Jones, 2016/11/10
- [Qemu-devel] [kvm-unit-tests PATCH v5 02/11] arm64: fix get_"sysreg32" and make MPIDR 64bit, Andrew Jones, 2016/11/10
- [Qemu-devel] [kvm-unit-tests PATCH v5 03/11] arm/arm64: smp: support more than 8 cpus, Andrew Jones, 2016/11/10
- [Qemu-devel] [kvm-unit-tests PATCH v5 04/11] arm/arm64: add some delay routines, Andrew Jones, 2016/11/10
- [Qemu-devel] [kvm-unit-tests PATCH v5 05/11] arm/arm64: irq enable/disable, Andrew Jones, 2016/11/10
- [Qemu-devel] [kvm-unit-tests PATCH v5 06/11] arm/arm64: add initial gicv2 support, Andrew Jones, 2016/11/10
- Re: [Qemu-devel] [kvm-unit-tests PATCH v5 06/11] arm/arm64: add initial gicv2 support, Andre Przywara, 2016/11/11
- [Qemu-devel] [kvm-unit-tests PATCH v5 07/11] arm/arm64: gicv2: add an IPI test, Andrew Jones, 2016/11/10
[Qemu-devel] [kvm-unit-tests PATCH v5 08/11] libcflat: add IS_ALIGNED() macro, and page sizes, Andrew Jones, 2016/11/10
[Qemu-devel] [kvm-unit-tests PATCH v5 09/11] arm/arm64: add initial gicv3 support, Andrew Jones, 2016/11/10