[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/12] block/nbd: Fix the leaked visitor
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 01/12] block/nbd: Fix the leaked visitor |
Date: |
Fri, 11 Nov 2016 17:55:00 +0100 |
From: Ashijeet Acharya <address@hidden>
This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it. The leak was introduced by the commit 491d6c7.
Signed-off-by: Ashijeet Acharya <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nbd.c b/block/nbd.c
index 9cff839..35f24be 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -536,6 +536,7 @@ static void nbd_refresh_filename(BlockDriverState *bs,
QDict *options)
ov = qobject_output_visitor_new(&saddr_qdict);
visit_type_SocketAddress(ov, NULL, &s->saddr, &error_abort);
visit_complete(ov, &saddr_qdict);
+ visit_free(ov);
assert(qobject_type(saddr_qdict) == QTYPE_QDICT);
qdict_put_obj(opts, "server", saddr_qdict);
--
1.8.3.1
- [Qemu-devel] [PULL 00/12] Block layer patches for 2.8.0-rc0, Kevin Wolf, 2016/11/11
- [Qemu-devel] [PULL 01/12] block/nbd: Fix the leaked visitor,
Kevin Wolf <=
- [Qemu-devel] [PULL 02/12] block/ssh: Code cleanup for unused parameter, Kevin Wolf, 2016/11/11
- [Qemu-devel] [PULL 03/12] hmp: Make block_stream set an explicit job ID, Kevin Wolf, 2016/11/11
- [Qemu-devel] [PULL 04/12] raw_bsd: move check to prevent overflow, Kevin Wolf, 2016/11/11
- [Qemu-devel] [PULL 05/12] raw_bsd: don't check size alignment when only offset is set, Kevin Wolf, 2016/11/11
- [Qemu-devel] [PULL 06/12] qcow2: Remove stale FIXME comment, Kevin Wolf, 2016/11/11
- [Qemu-devel] [PULL 07/12] nfs: Fix memory leak in nfs_file_create(), Kevin Wolf, 2016/11/11
- [Qemu-devel] [PULL 08/12] block: Fix bdrv_iterate_format() sorting, Kevin Wolf, 2016/11/11
- [Qemu-devel] [PULL 09/12] block: Emit modules in bdrv_iterate_format(), Kevin Wolf, 2016/11/11
- [Qemu-devel] [PULL 11/12] iotests: Always use -machine accel=qtest, Kevin Wolf, 2016/11/11
- [Qemu-devel] [PULL 10/12] iotests: Skip test 162 if there is no SSH support, Kevin Wolf, 2016/11/11