Re: [Qemu-devel] [PATCH v2 5/5] Plumb the HAXM-based hardware acceleration support

[Paolo Bonzini]

On 11/11/2016 12:28, Vincent Palatin wrote:
> +            /*
> +             * In Hax, the qemu allocate the virtual address, and HAX kernel
> +             * populate the memory with physical memory. Currently we have no
> +             * paging, so user should make sure enough free memory in advance
> +             */
> +            if (hax_enabled()) {
> +                int ret;
> +                ret = hax_populate_ram((uint64_t)(uintptr_t)new_block->host,
> +                                       new_block->max_length);
> +                if (ret < 0) {
> +                    error_setg(errp, "Hax failed to populate ram");
> +                    return;
> +                }
> +            }
> +
>              if (!new_block->host) {
>                  error_setg_errno(errp, errno,
>                                   "cannot set up guest memory '%s'",

The hax_enabled() check should be after the "if (!new_block->host)" block.

Paolo