qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] 9pfs: adjust the order of resource cleanup in d


From: Greg Kurz
Subject: Re: [Qemu-devel] [PATCH] 9pfs: adjust the order of resource cleanup in device unrealize
Date: Tue, 15 Nov 2016 11:15:19 +0100

Hi Li,

Please incorporate this patch in your cleanup series since it depends on it.

On Mon, 14 Nov 2016 20:38:57 -0500
Li Qiang <address@hidden> wrote:

> From: Li Qiang <address@hidden>
> 
> Unrealize should undo things that were set during realize in
> reverse order. This is what this patch does.
> 

So should do the error path in realize actually. :)

> Signed-off-by: Li Qiang <address@hidden>
> ---
>  hw/9pfs/9p.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index aea7e9d..f7e14ac 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -3530,8 +3530,8 @@ out:
>  
>  void v9fs_device_unrealize_common(V9fsState *s, Error **errp)
>  {
> -    g_free(s->ctx.fs_root);
>      g_free(s->tag);
> +    g_free(s->ctx.fs_root);
>  }
>  
>  typedef struct VirtfsCoResetData {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]