Re: [Qemu-devel] [PATCH for-2.9] qmp: Report QOM type name on query-cpu-definitions

[Eric Blake]

On 11/16/2016 12:21 PM, Eduardo Habkost wrote:
> The new typename attribute on query-cpu-definitions will be used
> to help management software use device-list-properties to check
> which properties can be set using -cpu or -global for the CPU
> model.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  qapi-schema.json            | 4 +++-
>  target-arm/helper.c         | 1 +
>  target-i386/cpu.c           | 1 +
>  target-ppc/translate_init.c | 1 +
>  target-s390x/cpu_models.c   | 1 +
>  5 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index b0b4bf6..9a3bdd4 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3216,6 +3216,8 @@
>  # @unavailable-features: #optional List of properties that prevent
>  #                        the CPU model from running in the current
>  #                        host. (since 2.8)
> +# @typename: Type name that can be used as argument to 
> @device-list-properties,
> +#            to introspect properties configurable using -cpu or -global.

Missing a '(since 2.9)' designation.

>  #
>  # @unavailable-features is a list of QOM property names that
>  # represent CPU model attributes that prevent the CPU from running.
> @@ -3237,7 +3239,7 @@
>  ##
>  { 'struct': 'CpuDefinitionInfo',
>    'data': { 'name': 'str', '*migration-safe': 'bool', 'static': 'bool',
> -            '*unavailable-features': [ 'str' ] } }
> +            '*unavailable-features': [ 'str' ], 'typename': 'str' } }
>  

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature