[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [patch v3 15/18] target-i386: Use new deposit and extract o
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [patch v3 15/18] target-i386: Use new deposit and extract ops |
Date: |
Wed, 16 Nov 2016 21:03:42 +0100 |
A couple of places where it was easy to identify a right-shift
followed by an extract or and-with-immediate, and the obvious
sign-extract from a high byte register.
Acked-by: Eduardo Habkost <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target-i386/translate.c | 45 +++++++++++++++++++++++----------------------
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 324103c..4d6d36f 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -383,8 +383,7 @@ static void gen_op_mov_reg_v(TCGMemOp ot, int reg, TCGv t0)
static inline void gen_op_mov_v_reg(TCGMemOp ot, TCGv t0, int reg)
{
if (ot == MO_8 && byte_reg_is_xH(reg)) {
- tcg_gen_shri_tl(t0, cpu_regs[reg - 4], 8);
- tcg_gen_ext8u_tl(t0, t0);
+ tcg_gen_extract_tl(t0, cpu_regs[reg - 4], 8, 8);
} else {
tcg_gen_mov_tl(t0, cpu_regs[reg]);
}
@@ -3756,8 +3755,7 @@ static void gen_sse(CPUX86State *env, DisasContext *s,
int b,
/* Extract the LEN into a mask. Lengths larger than
operand size get all ones. */
- tcg_gen_shri_tl(cpu_A0, cpu_regs[s->vex_v], 8);
- tcg_gen_ext8u_tl(cpu_A0, cpu_A0);
+ tcg_gen_extract_tl(cpu_A0, cpu_regs[s->vex_v], 8, 8);
tcg_gen_movcond_tl(TCG_COND_LEU, cpu_A0, cpu_A0, bound,
cpu_A0, bound);
tcg_temp_free(bound);
@@ -3908,9 +3906,8 @@ static void gen_sse(CPUX86State *env, DisasContext *s,
int b,
gen_compute_eflags(s);
}
carry_in = cpu_tmp0;
- tcg_gen_shri_tl(carry_in, cpu_cc_src,
- ctz32(b == 0x1f6 ? CC_C : CC_O));
- tcg_gen_andi_tl(carry_in, carry_in, 1);
+ tcg_gen_extract_tl(carry_in, cpu_cc_src,
+ ctz32(b == 0x1f6 ? CC_C : CC_O), 1);
}
switch (ot) {
@@ -5435,21 +5432,25 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
rm = (modrm & 7) | REX_B(s);
if (mod == 3) {
- gen_op_mov_v_reg(ot, cpu_T0, rm);
- switch (s_ot) {
- case MO_UB:
- tcg_gen_ext8u_tl(cpu_T0, cpu_T0);
- break;
- case MO_SB:
- tcg_gen_ext8s_tl(cpu_T0, cpu_T0);
- break;
- case MO_UW:
- tcg_gen_ext16u_tl(cpu_T0, cpu_T0);
- break;
- default:
- case MO_SW:
- tcg_gen_ext16s_tl(cpu_T0, cpu_T0);
- break;
+ if (s_ot == MO_SB && byte_reg_is_xH(rm)) {
+ tcg_gen_sextract_tl(cpu_T0, cpu_regs[rm - 4], 8, 8);
+ } else {
+ gen_op_mov_v_reg(ot, cpu_T0, rm);
+ switch (s_ot) {
+ case MO_UB:
+ tcg_gen_ext8u_tl(cpu_T0, cpu_T0);
+ break;
+ case MO_SB:
+ tcg_gen_ext8s_tl(cpu_T0, cpu_T0);
+ break;
+ case MO_UW:
+ tcg_gen_ext16u_tl(cpu_T0, cpu_T0);
+ break;
+ default:
+ case MO_SW:
+ tcg_gen_ext16s_tl(cpu_T0, cpu_T0);
+ break;
+ }
}
gen_op_mov_reg_v(d_ot, reg, cpu_T0);
} else {
--
2.7.4
- [Qemu-devel] [patch v3 03/18] tcg: Add deposit_z expander, (continued)
- [Qemu-devel] [patch v3 03/18] tcg: Add deposit_z expander, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 05/18] tcg/arm: Move isa detection to tcg-target.h, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 07/18] tcg/i386: Implement field extraction opcodes, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 06/18] tcg/arm: Implement field extraction opcodes, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 08/18] tcg/mips: Implement field extraction opcodes, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 09/18] tcg/ppc: Implement field extraction opcodes, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 10/18] tcg/s390: Expose host facilities to tcg-target.h, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 12/18] tcg/s390: Support deposit into zero, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 11/18] tcg/s390: Implement field extraction opcodes, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 13/18] target-alpha: Use deposit and extract ops, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 15/18] target-i386: Use new deposit and extract ops,
Richard Henderson <=
- [Qemu-devel] [patch v3 14/18] target-arm: Use new deposit and extract ops, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 16/18] target-mips: Use the new extract op, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 17/18] target-ppc: Use the new deposit and extract ops, Richard Henderson, 2016/11/16
- [Qemu-devel] [patch v3 18/18] target-s390x: Use the new deposit and extract ops, Richard Henderson, 2016/11/16
- Re: [Qemu-devel] [patch v3 00/18] tcg field extract primitives, no-reply, 2016/11/16