Re: [Qemu-devel] [PATCH v4 14/15] docs: add qemu logo

[Marc-André Lureau]

Hi

On Thu, Nov 10, 2016 at 7:45 PM Daniel P. Berrange <address@hidden>
wrote:

> On Thu, Nov 10, 2016 at 07:22:08PM +0400, Marc-André Lureau wrote:
> > The pdf (needed by texi2pdf for vectorized images) was generated thanks
> > to inkscape, from the pc-bios/qemu_logo.svg file. Move the original file
> > in the docs folder too, since it's not being referenced elsewhere.
>
> I don't think we should be moving the qemu_logo.svg file.


> The pc-bios has 3 other logo files qemu_logo_no_text.svg, qemu-icon.bmp
> and qemu-nsis.ico. Having those three logo files in pc-bios, and the
> other file in docs/ is unhelpful. IMHO they should all live together,
> either all in docs/ or all in pc-bios/
>

let's keep them in pc-bios for now then. However, the new pdf file can be
in docs?


>
> I'd probably pick docs/ as its a bit strange to be looking for logos
> in a bios sub-dir
>

Hmm, we could add docs/ in data_dir[] when running from the build-tree.
That should make qemu_find_file() returns files from docs/ too, so we could
move the logos.
-- 
Marc-André Lureau