Re: [Qemu-devel] [PATCH 10/25] target-tricore: Use clz opcode

[Bastian Koppelmann]

On 11/17/2016 03:42 PM, Bastian Koppelmann wrote:
> On 11/16/2016 08:25 PM, Richard Henderson wrote:
>> diff --git a/target-tricore/translate.c b/target-tricore/translate.c
>> index 36f734a..69cdfb9 100644
>> --- a/target-tricore/translate.c
>> +++ b/target-tricore/translate.c
>> @@ -6367,7 +6367,8 @@ static void decode_rr_logical_shift(CPUTriCoreState 
>> *env, DisasContext *ctx)
>>          tcg_gen_andc_tl(cpu_gpr_d[r3], cpu_gpr_d[r1], cpu_gpr_d[r2]);
>>          break;
>>      case OPC2_32_RR_CLO:
>> -        gen_helper_clo(cpu_gpr_d[r3], cpu_gpr_d[r1]);
>> +        tcg_gen_not_tl(cpu_gpr_d[r3], cpu_gpr_d[r1]);
>> +        tcg_gen_clzi_tl(cpu_gpr_d[r3], cpu_gpr_d[r3], TARGET_LONG_BITS);
> 
> This doesn't work for r1 = 0. It returns 0x1f, but should return 0. I
> guess the error is not here, but I couldn't figure out where exactly it is.

Ah I forgot to mention -- I'm running this on x86_64.

Cheers,
    Bastian