[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] virtio: add missing vdev->broken check
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] virtio: add missing vdev->broken check |
Date: |
Fri, 18 Nov 2016 10:55:56 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Thu, Nov 17, 2016 at 01:24:47PM +0100, Cornelia Huck wrote:
> On Thu, 17 Nov 2016 10:58:30 +0000
> Stefan Hajnoczi <address@hidden> wrote:
>
> > On Thu, Nov 17, 2016 at 09:31:18AM +0100, Cornelia Huck wrote:
> > > On Wed, 16 Nov 2016 21:53:07 +0000
> > > Stefan Hajnoczi <address@hidden> wrote:
> > >
> > > > virtio_queue_notify_vq() checks vdev->broken before invoking the
> > > > handler, virtio_queue_notify_aio_vq() should too.
> > > >
> > > > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > > > ---
> > > > hw/virtio/virtio.c | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > >
> > > Reviewed-by: Cornelia Huck <address@hidden>
> > >
> > > I think this makes sense as a fix independent of your other patches.
> >
> > I'm not aware of an actual bug caused by this. virtio_queue_pop()
> > returns NULL when the device is broken.
> >
> > This is more for consistency than correctness, so I didn't add
> > qemu-stable, -rc1, or send it as a separate fix.
>
> Fair enough. It was more "we should add this patch even if we don't use
> the other patches in this series".
Okay.
Stefan
signature.asc
Description: PGP signature
[Qemu-devel] [PATCH 3/3] virtio-scsi: suppress virtqueue kick during processing, Stefan Hajnoczi, 2016/11/16
Re: [Qemu-devel] [PATCH 0/3] virtio: disable notifications in blk and scsi, Michael S. Tsirkin, 2016/11/16
Re: [Qemu-devel] [PATCH 0/3] virtio: disable notifications in blk and scsi, Christian Borntraeger, 2016/11/17