qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'


From: Paolo Bonzini
Subject: Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'
Date: Tue, 22 Nov 2016 01:49:37 -0500 (EST)

> On Nov 21, 2016, at 3:46 PM, Eric Blake wrote:
> > On 11/21/2016 02:36 PM, Eric Blake wrote:
> > > but I'd argue that using qobject_from_jsonf() is already less-than-
> > > useful.
> >
> > In fact, we are down to only a handful of users of our modified
> > 'jsonf'
> > format (that is, strings that mix JSON with % modifiers):
> >
> > hw/pci/pcie_aer.c: build a 5-element QDict
> > monitor.c: build a 1-element QDict which contains a 2-element QDict
> > qapi/qmp-dispatch.c: build a 2-element QDict
> > qapi/qmp-event.c: Build a 2-element QDict
> >
> > plus the testsuite (check-qjson.c).
> > I'm severely tempted to just rip out all of the poorly-
> > underdocumented % parsing from the JSON parser,

Go ahead.  In fact, at least pci_aer.c should either use a QAPI type
(and it doesn't only because the error injection command is
HMP-only) or can just use a C struct.  The others are mostly
internal details and can build the QDict manual.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]