Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

[Olaf Hering]

Ping.

On Fri, Nov 18, Olaf Hering wrote:

> On Fri, Nov 18, Olaf Hering wrote:
> 
> > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq)
> > +        if (!blk_split_discard(ioreq, req->sector_number, 
> > req->nr_sectors)) {
> > +            goto err;
> 
> How is error handling supposed to work here?
> Initially I forgot the "!", which just hung the mkfs command in domU.
> I have not yet tried to force errors in other part of that function.


Olaf

signature.asc
Description: PGP signature