[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qob
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf() |
Date: |
Thu, 24 Nov 2016 10:32:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/24/2016 05:07 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> address@hidden reported a runtime failure on a
>> 32-bit Mac OS compilation, where "%"PRId64 expands to "%qd".
>> Fortunately, we had very few spots that were relying on our
>> pseudo-printf JSON parsing of int64_t numbers, so it was
>> easier to just convert callers to stick to safer %lld.
>>
>> The remaining uses of pseudo-printf handling are more complex;
>> there are only 3 users in the released codebased, but LOTS of
>> users in the testsuite (via wrapper functions like qmp()); I
>> will be posting a followup series that rips out the remaining
>> uses of dynamic JSON, but it will be 2.9 material, while
>> these (first three) patches qualify for 2.8. The fourth patch
>> is RFC; not intended to be applied now, but shows how I tested
>> patch 3/4; it will probably reappear in the later 2.9 series.
>
> I can take the first three through my tree.
You mentioned some possible touchups - do you want to make those, or
have me send a v3?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf(), Eric Blake, 2016/11/23
- [Qemu-devel] [PATCH v2 2/4] test-qga: Avoid qobject_from_jsonv("%"PRId64), Eric Blake, 2016/11/23
- [Qemu-devel] [PATCH v2 1/4] qmp-event: Avoid qobject_from_jsonf("%"PRId64), Eric Blake, 2016/11/23
- [Qemu-devel] [PATCH v2 4/4] RFC: qapi: Drop support for qobject_from_jsonf("%"PRId64), Eric Blake, 2016/11/23
- [Qemu-devel] [PATCH v2 3/4] tests: Avoid qobject_from_jsonf("%"PRId64), Eric Blake, 2016/11/23
- Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf(), Markus Armbruster, 2016/11/24
- Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf(), no-reply, 2016/11/29