[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.8 0/5] 9pfs: fix session reset
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PATCH for-2.8 0/5] 9pfs: fix session reset |
Date: |
Fri, 25 Nov 2016 12:54:13 +0100 |
User-agent: |
StGit/0.17.1-dirty |
This series addresses two issues we currently have:
1) the version operation only does a partial cleanup of a previously active
session. It can leave unfinished PDUs and stale fids behind. This violates
the 9p specification.
2) if a guest mounts a 9p share and is then resetted with system_reset, it
remains unmigratable because the migration blocker isn't cleared.
The current implementation of the official 9p client in the linux kernel
cannot hit 1) because it only uses the version operation at mount time.
Anyway, this could speed-up reset since we wouldn't simply wait for pending
I/O to complete as we do know.
And it is very easy to hit 2).
Please review.
Stefan,
Both issues have always been around, but it is the first time we can fix
them since 2.8 introduces vdc->reset. Do you think this is ok for 2.8 or
would you prefer to postpone this to 2.9 ?
Cheers.
--
Greg
---
Greg Kurz (5):
9pfs: add missing coroutine_fn annotations
9pfs: cancel active PDUs in virtfs_reset()
9pfs: always free fids in virtfs_reset()
9pfs: drop useless loop in v9fs_reset()
9pfs: clear migration blocker when resetting the device
hw/9pfs/9p.c | 59 ++++++++++++++++++++++++++++++++++++++--------------------
1 file changed, 39 insertions(+), 20 deletions(-)
- [Qemu-devel] [PATCH for-2.8 0/5] 9pfs: fix session reset,
Greg Kurz <=
- [Qemu-devel] [PATCH for-2.8 1/5] 9pfs: add missing coroutine_fn annotations, Greg Kurz, 2016/11/25
- [Qemu-devel] [PATCH for-2.8 2/5] 9pfs: cancel active PDUs in virtfs_reset(), Greg Kurz, 2016/11/25
- [Qemu-devel] [PATCH for-2.8 3/5] 9pfs: always free fids in virtfs_reset(), Greg Kurz, 2016/11/25
- [Qemu-devel] [PATCH for-2.8 4/5] 9pfs: drop useless loop in v9fs_reset(), Greg Kurz, 2016/11/25
- [Qemu-devel] [PATCH for-2.8 5/5] 9pfs: clear migration blocker when resetting the device, Greg Kurz, 2016/11/25