qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 10/11] tcg-mips: Adjust qemu_ld/st for mips64


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v3 10/11] tcg-mips: Adjust qemu_ld/st for mips64
Date: Fri, 25 Nov 2016 12:55:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 11/25/2016 04:31 AM, Jin Guojie wrote:
-#define LO_OFF    (MIPS_BE * 4)
-#define HI_OFF    (4 - LO_OFF)
+# define LO_OFF  (MIPS_BE * sizeof(long))
+# define HI_OFF  (sizeof(long) - LO_OFF)

For n32, sizeof(long) == 4, and for n64, sizeof(long) == 8. So in the end this change must be wrong for big-endian.

Surely using link_error, as my patch did, to assert at compile-time that these values were never used for TCG_TARGET_REGS == 64 is better.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]