qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX ma


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros
Date: Mon, 28 Nov 2016 08:39:21 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

The "{disas, slirp}: " prefix is unusual.  Better: "disas, slirp: ".
But I'd instead split the patch into the slirp part, where you really
replace stuff, and the disas part, where you merely drop an unused macro
definition.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]